Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: multiple accounts #404

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

alangecker
Copy link

@alangecker alangecker commented Aug 21, 2022

first draft of multiple element instances in the same electron BrowserWindow.

Works so far, but there is still a lot to do (see ToDo list) and I can't promise that I'll find time for that in the next weeks 🙃

related element-hq/element-web#2320

Screenrecording showing switching between the instances

ToDo's

  • proper react menu with (webpack?) building
  • show badge counts in menu
  • aggregate badge counts for tray
  • open correct instance on notification click
  • make multiple profiles optional (via lab flag?)
  • apply a change in theme to all instances + menu
  • menu i18n
  • menu styling
  • instance chooser for protocol links
  • bring back electrons dropdown menu
  • accessibility
  • how to handle 'page-favicon-updated' and 'page-title-updated' now? (tray.ts)
  • tests
  • proper session partition naming, renaming possible?
  • migration of existing sessions

This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 21, 2022
@yuuyins
Copy link

yuuyins commented Oct 19, 2022

nice! i think the UI should be iterated. instead of using yet another column for that which convolutes the UI, try using the already existing user button in the top left for switching accounts.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants